Bug#1032659: ITP: golang-github-go-task-slim-sprig -- Useful template functions for Go templates.
Hi Mark,
I will be willing to sponsor this package (mainly as I am looking to using it
in Debos). Your packaging looks generally good, but I have noticed a few minor
issues with the Git repo / packaging, let me know if you can fix these or if
you'd like me to do so.
- d/copyright: "Copyright: 2019 Task" seems.. wrong? Also, for the record
there is no explicit licence file in the upstream repository, but the GitHub
page says MIT.
- The package's commit history seems to modify the original source, e.g.
908e6bca ("Ignore _build and quilt .pc dirs via .gitignore") which is then
reverted by af533953 ("Import Debian changes 2.20.0-1"). It would be far
cleaner to drop these commits.
- 6ef11ba6 ("fixup: unstable build submission") seems to be wrong. As you're
not uploading into unstable, you should leave it as UNRELEASED.
- v3.0.0 has been released upstream. What would the plan be for importing
that?
- The TestShuffle function seems to fail (heh, is this test even deterministic
?):
> $ gbp buildpackage --git-pbuilder
> === RUN TestShuffle
> functions_test.go:82:
> Error Trace: /build/golang-github-go-task-slim-sprig-
> 2.20.0/_build/src/github.com/go-task/slim-sprig/functions_test.go:82
> Error: Received unexpected error:
> Expected 'rldo HWlloe', got 'olldolr WeH'
> Test: TestShuffle
> --- FAIL: TestShuffle (0.00s)
>
> dh_auto_test: error: cd _build && go test -vet=off -v -p 16 github.com/go-
> task/slim-sprig returned exit code 1
Thanks!
Chris
Reply to: