[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1055192: RFS: golang-github-apenella-go-ansible



Hi weepingclown,

I've had a look at your three packages, and everything you've done is perfect.

Some feedback regarding apanella-go-ansible:

  * Formatting: inconsistent indenting in d/control's B-Deps field

  * Instead of removing usr/bin after dh_auto_install, I recommend you use
    dh-golang's settings to do that instead. Have a look at the
    Debian::Debhelper::Buildsystem::golang manpage, specifically
    DH_GOLANG_EXCLUDES and DH_GOLANG_EXCLUDES_ALL env vars.

  * Is examples/ansibleplaybook-simple-embedfs/embedfs/
    necessary in DH_GOLANG_INSTALL_EXTRA?

  * You may want to rename d/examples to
    d/golang-github-apanella-go-ansible-dev.examples

I question the need for stretchr-testify in the Depends field, but if other
packages have it, then no worries.

Kind regards
Maytham

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: