[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1063380: ITP: libuio -- Linux Kernel UserspaceIO helper library



Hi Dima,

> On 7 Feb 2024, at 18:27, Dima Kogan <dkogan@debian.org> wrote:
> 
> Hi. Thanks for your contribution. I looked at the upstream code a tiny
> bit, and it looks like it might have portability bug, at least on
> big-endian architectures. For instance:
> 
>  https://github.com/missinglinkelectronics/libuio/blob/6ef3d8d096a641686bfdd112035aa04aa16fe81a/irq.c#L78
> 
> This assumes that sizeof(long)==4. Maybe this is benign, but it would be
> nice to fix. Are you upstream or do you know upstream? Can yall fix
> these?

The kernel expects a 4 byte write here, since unsigned long is defined as at least 32 bit this shall work on all architectures.

If your concern is about endianess this is not in the current scope of libuio and needs to be addressed by a higher layer.

I am very familiar with library and in close contact with upstream.

Best regards 
Manuel

Reply to: