[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#583802: xdm: init script should support the "status" option



On 2010-06-02 13:38 +0200, Julien Cristau wrote:

> On Tue, Jun  1, 2010 at 09:44:49 +0200, Sven Joachim wrote:
>
>> diff --git a/debian/xdm.init b/debian/xdm.init
>> index 93fcb62..4127dff 100644
>> --- a/debian/xdm.init
>> +++ b/debian/xdm.init
>> @@ -113,8 +113,12 @@ case "$1" in
>>      log_end_msg 0
>>    ;;
>>  
>> +  status)
>> +	status_of_proc -p $PIDFILE $DAEMON xdm && exit 0 || exit $?
>> +  ;;
>> +
> Couldn't this just be:
> status_of_proc -p $PIDFILE $DAEMON xdm
> ?

Maybe.  I just used the code from /etc/init.d/skeleton.

> (the script is set -e, which I suppose might be a bad idea, but that's a
> separate discussion...)

Yes, set -e is not recommended in init scripts, see the discussion in
#562506.

Cheers,
       Sven



Reply to: