Bug#781270: python3-apt: Exception gives Ubuntu-related link on Debian
Control: tag -1 pending
On Thu, Mar 26, 2015 at 07:47:25PM +0100, W. Martin Borgert wrote:
> Package: python3-apt
> Version: 0.9.3.11
> Severity: minor
>
> In apt/package.py:1063 is a link that is probably fine for Ubuntu,
> but wrong for Debian:
>
> except HTTPError:
> res = _("The list of changes is not available yet.\n\n"
> "Please use http://launchpad.net/ubuntu/+source/%s/";
> "%s/+changelog\n"
> "until the changes become available or try again "
> "later.") % (src_pkg, src_ver)
> return res if isinstance(res, unicode) else res.decode("utf-8")
Thanks for your bug report. I fixed this in git with the
following commit:
>From 7733ef642461daf7bd82aaeb7c9f9b184455b19d Mon Sep 17 00:00:00 2001
From: Julian Andres Klode <jak@debian.org>
Date: Wed, 10 Jun 2015 17:45:57 +0200
Subject: [PATCH] apt.package: Only reference Launchpad for missing changelogs
on Ubuntu
The new message is not really helpful, but hey, who cares.
Closes: #781270
---
apt/package.py | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/apt/package.py b/apt/package.py
index 8561d3c..069b21d 100644
--- a/apt/package.py
+++ b/apt/package.py
@@ -1060,11 +1060,15 @@ class Package(object):
self._changelog = changelog
except HTTPError:
- res = _("The list of changes is not available yet.\n\n"
- "Please use http://launchpad.net/ubuntu/+source/%s/";
- "%s/+changelog\n"
- "until the changes become available or try again "
- "later.") % (src_pkg, src_ver)
+ if self.candidate.origins[0].origin == "Ubuntu":
+ res = _("The list of changes is not available yet.\n\n"
+ "Please use "
+ "http://launchpad.net/ubuntu/+source/%s/";
+ "%s/+changelog\n"
+ "until the changes become available or try again "
+ "later.") % (src_pkg, src_ver)
+ else:
+ res = _("The list of changes is not available")
return res if isinstance(res, unicode) else res.decode("utf-8")
except (IOError, BadStatusLine):
res = _("Failed to download the list of changes. \nPlease "
--
2.1.4
--
Julian Andres Klode - Debian Developer, Ubuntu Member
See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
Be friendly, do not top-post, and follow RFC 1855 "Netiquette".
- If you don't I might ignore you.
Reply to: