[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#733489: [PATCH] apt/package.py: Replaced pre_depend with rawtype in BaseDependency.__repr__ as rawtype gives more information including the information from pre_depend.



On Mon, Jun 29, 2015 at 03:34:53PM +0200, Michael Schaller wrote:
> 
> On 06/28/2015 10:39 PM, Julian Andres Klode wrote:
> > On Sun, Jun 28, 2015 at 01:49:17PM +0200, Michael Schaller wrote:
> >
> > I reworded it a bit:
> > - Dropped the filename to make the subject shorter
> > - Dropped the '.' at the end of the subject
> > - Changed from past to present tense
> > - Made one sentence out of the paragraph
> >
> > and applied it to the debian/sid branch.
> >
> 
> Thanks. The following patches hopefully go smoother...
> 
> The next patch is what previously patch 3/5 was. Please let me know what you
> think of the added constructor argument. If you think that this change could
> break third-party code then the rawtype could also be inferred by going
> through the list of BaseDependency objects, getting their rawtype and
> ensuring that they all have the same rawtype.

Committed. This *should not* break anything. If it does, we'll
see it.

I dropped to po/ part, as there was no new string in there, so
it was just mostly-unrelated noise (just line number changes).

A longer paragraph would have been nice, I forgot about this
before pushing it.

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Be friendly, do not top-post, and follow RFC 1855 "Netiquette".
    - If you don't I might ignore you.


Reply to: