On Wed, May 03, 2017 at 01:49:57PM +0200, Michael wrote: > # LANG=C apt-cache showsrc xmms2-plugin-id3v2 xmms2-plugin-mad > xmms2-plugin-vorbis > /dev/null > W: Unable to locate package xmms2-plugin-mad > W: Unable to locate package xmms2-plugin-vorbis That is a good catch – and thanks for the report and for working on patch! > A possible fix would be: […] > ... unaudited. Please review this patch; maybe only one of those result > lines has to be moved! I guess (= haven't looked too hard yet) that this is okay even through moving found_this should be enough already. A patch should really come with a testcase through as this is just going to break one way or the other in the future otherwise. Especially as showsrc hasn't that many tests at all at the moment. The README has some information on running and writing a test/integration script and looking at existing ones should be helpful, too, but feel free to ask here or on IRC (#debian-apt) if something isn't clear! > And please - fix the coding style. Not only within private-show.cc but also > with other apt source files. > It's heavily mixed with tabs and spaces and quite ugly with tabstop!=8. > Please, use either tabs _or_ spaces, but not both. See the README about this - quoting a bit: | The source code uses in most parts a relatively uncommon indent convention, | namely 3 spaces with 8 space tab […] Adhering to it avoids unnecessary | code-churn destroying history (aka: `git blame`) […] for vim […]: | `setlocal shiftwidth=3 noexpandtab tabstop=8` Nobody said that we like it, but reformatting means a lot of additional work nobody likes either from history-destroying to making backports harder which are both very important for us as the team has to support released apt versions for many years (which also means quite a few are supported in parallel). Best regards David Kalnischkies
Attachment:
signature.asc
Description: PGP signature