On Sat, Apr 28, 2018 at 11:20:46PM -0500, Steve M. Robbins wrote:
> Your package relies on this behaviour and now fails to build since
> googletest version 1.8.0-9 no longer installs the duplicate header
> files.
*sigh* Seems like we can solve this by:
diff --git a/test/libapt/CMakeLists.txt b/test/libapt/CMakeLists.txt
index 86c0b28b5..c770d57bb 100644
--- a/test/libapt/CMakeLists.txt
+++ b/test/libapt/CMakeLists.txt
@@ -16,7 +16,7 @@ if(NOT GTEST_FOUND AND EXISTS ${GTEST_ROOT})
set(GTEST_LIBRARIES "-lgtest")
set(GTEST_DEPENDENCIES "gtest")
set(GTEST_FOUND TRUE)
- find_path(GTEST_INCLUDE_DIRS NAMES gtest/gtest.h)
+ find_path(GTEST_INCLUDE_DIRS NAMES gtest/gtest.h PATHS /usr/src/googletest/googletest/include)
message(STATUS "Found GTest at ${GTEST_ROOT}, headers at ${GTEST_INCLUDE_DIRS}")
endif()
Not really knowledgeable enough about cmake through to know if that is
the best we can do – it looks kinda ugly/dirty.
We could also switch to using the prebuilt library in libgtest-dev; it
is happily picked up if available (which is why I didn't notice before).
Not sure how the version constraints need to look to deal sanely with
the constant name-changing of gtests packaging through…
(or well, we probably need to end up with a mix of all that to keep
working everywhere, so… no patch, just a hint for others looking into
it as I was a bit surprised it worked for me locally…).
Best regards
David Kalnischkies
Attachment:
signature.asc
Description: PGP signature