Re: [PATCH v3 00/18] fleecing-hook driver for backup
On Wed, Oct 03, 2018 at 10:45:29AM -0500, Eric Blake wrote:
> [redirecting this to NBD list]
>
> On 10/3/18 10:36 AM, Vladimir Sementsov-Ogievskiy wrote:
>
> > hmm, about different ports, it's funny, but NBD-spec is directly against
> > different ports for new style negotiation:
> > A client who wants to use the new style negotiation SHOULD connect on
> > the IANA-reserved port for NBD, 10809. The server MAY listen on other
> > ports as well, but it SHOULD use the old style handshake on those.
> >
> > also, next sentence is strange too:
> > The server SHOULD refuse to allow oldstyle negotiations on the newstyle
> > port.
> >
> > refuse? Refuse to whom? It's a server, who choose negotiation type. Or
> > this means, that it should refuse to start at all. so refuse to server
> > admin, not to NBD client? sounds strange. Should it be "Server SHOULD
> > NOT use the old style on port 10809"?
>
> We definitely need to tweak that wording, especially since we are trying to
> get rid of oldstyle servers and clients in favor of fixed newstyle.
Yeah, that is outdated now. It made (some) sense at the time when it was
still a good idea to run oldstyle and newstyle from the same server, but
that's not the case anymore.
So yeah, I agree that we should drop that nowadays.
--
Could you people please use IRC like normal people?!?
-- Amaya Rodrigo Sastre, trying to quiet down the buzz in the DebConf 2008
Hacklab
Reply to: