Re: [Ocfs2-devel] [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show
- To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
- Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>, jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, cluster-devel@redhat.com, xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org, linux-um@lists.infradead.org, nbd@other.debian.org, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
- Subject: Re: [Ocfs2-devel] [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show
- From: "Martin K. Petersen" <martin.petersen@oracle.com>
- Date: Wed, 06 Apr 2022 23:19:34 -0400
- Message-id: <[🔎] yq1h775ins6.fsf@ca-mkp.ca.oracle.com>
- In-reply-to: <[🔎] 20220406060516.409838-16-hch@lst.de> (Christoph Hellwig via Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:04 +0200")
- References: <[🔎] 20220406060516.409838-1-hch@lst.de> <[🔎] 20220406060516.409838-16-hch@lst.de>
Christoph,
> Replace the open coded offset calculation with the proper helper.
> This is an ABI change in that the -1 for a misaligned partition is
> properly propagated, which can be considered a bug fix and maches what
> is done on the whole device.
Looks good.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
Reply to: