Re: [dm-devel] [PATCH 08/11] loop: remove a spurious clear of discard_alignment
- To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
- Cc: Jan Hoeppner <hoeppner@linux.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, Song Liu <song@kernel.org>, dm-devel@redhat.com, "Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>, linux-s390@vger.kernel.org, Richard Weinberger <richard@nod.at>, xen-devel@lists.xenproject.org, linux-um@lists.infradead.org, Mike Snitzer <snitzer@kernel.org>, Josef Bacik <josef@toxicpanda.com>, nbd@other.debian.org, linux-block@vger.kernel.org, Stefan Haberland <sth@linux.ibm.com>, linux-raid@vger.kernel.org, "Martin K. Petersen" <martin.petersen@oracle.com>, Johannes Berg <johannes@sipsolutions.net>, Roger Pau Monné <roger.pau@citrix.com>
- Subject: Re: [dm-devel] [PATCH 08/11] loop: remove a spurious clear of discard_alignment
- From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
- Date: Mon, 18 Apr 2022 17:04:11 +0900
- Message-id: <[🔎] 18032025-f1aa-2daa-d012-8996590ada6a@opensource.wdc.com>
- In-reply-to: <[🔎] 20220418045314.360785-9-hch@lst.de>
- References: <[🔎] 20220418045314.360785-1-hch@lst.de> <[🔎] 20220418045314.360785-9-hch@lst.de>
On 4/18/22 13:53, Christoph Hellwig wrote:
> The loop driver never sets a discard_alignment, so it also doens't need
> to clear it to zero.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/block/loop.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 976cf987b3920..61b642b966a08 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -789,7 +789,6 @@ static void loop_config_discard(struct loop_device *lo)
> blk_queue_max_discard_sectors(q, 0);
> blk_queue_max_write_zeroes_sectors(q, 0);
> }
> - q->limits.discard_alignment = 0;
> }
>
> struct loop_worker {
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
--
Damien Le Moal
Western Digital Research
Reply to: