[PATCH 1/5] null_blk: don't clear the flag that is not set
- To: <linux-block@vger.kernel.org>, <linux-bcache@vger.kernel.org>
- Cc: <axboe@kernel.dk>, <josef@toxicpanda.com>, <minchan@kernel.org>, <senozhatsky@chromium.org>, <colyli@suse.de>, <kent.overstreet@gmail.com>, <dlemoal@kernel.org>, <kch@nvidia.com>, <johannes.thumshirn@wdc.com>, <bvanassche@acm.org>, <vincent.fu@samsung.com>, <akinobu.mita@gmail.com>, <shinichiro.kawasaki@wdc.com>, <nbd@other.debian.org>
- Subject: [PATCH 1/5] null_blk: don't clear the flag that is not set
- From: Chaitanya Kulkarni <kch@nvidia.com>
- Date: Mon, 24 Apr 2023 00:30:19 -0700
- Message-id: <[🔎] 20230424073023.38935-2-kch@nvidia.com>
- In-reply-to: <20230424073023.38935-1-kch@nvidia.com>
- References: <20230424073023.38935-1-kch@nvidia.com>
QUEUE_FLAG_ADD_RANDOM is not set in null_add_dev() before we clear it.
There is no point in clearing the flag that is not set.
Remove blk_queue_flag_clear() for QUEUE_FLAG_ADD_RANDOM.
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/block/null_blk/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index b195b8b9fe32..b3fedafe301e 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -2144,7 +2144,6 @@ static int null_add_dev(struct nullb_device *dev)
nullb->q->queuedata = nullb;
blk_queue_flag_set(QUEUE_FLAG_NONROT, nullb->q);
- blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, nullb->q);
mutex_lock(&lock);
rv = ida_simple_get(&nullb_indexes, 0, 0, GFP_KERNEL);
--
2.40.0
Reply to: