Re: [PATCH 13/17] block: consolidate __invalidate_device and fsync_bdev
- To: Heiko Carstens <hca@linux.ibm.com>
- Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org>, Jens Axboe <axboe@kernel.dk>, Denis Efremov <efremov@linux.com>, Josef Bacik <josef@toxicpanda.com>, Stefan Haberland <sth@linux.ibm.com>, Jan Hoeppner <hoeppner@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev <agordeev@linux.ibm.com>, "Darrick J . Wong" <djwong@kernel.org>, Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>, linux-block@vger.kernel.org, nbd@other.debian.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
- Subject: Re: [PATCH 13/17] block: consolidate __invalidate_device and fsync_bdev
- From: Matthew Wilcox <willy@infradead.org>
- Date: Sat, 12 Aug 2023 21:43:21 +0100
- Message-id: <[🔎] ZNfu6THHySvQWViA@casper.infradead.org>
- In-reply-to: <[🔎] 20230812170400.11613-A-hca@linux.ibm.com>
- References: <[🔎] 20230811100828.1897174-1-hch@lst.de> <[🔎] 20230811100828.1897174-14-hch@lst.de> <20230812105133.GA11904@lst.de> <[🔎] 20230812170400.11613-A-hca@linux.ibm.com>
On Sat, Aug 12, 2023 at 07:04:00PM +0200, Heiko Carstens wrote:
> On Sat, Aug 12, 2023 at 12:51:33PM +0200, Christoph Hellwig wrote:
> > The buildbot pointed out correctly (but rather late), that the special
> > s390/dasd export needs a _MODULE postfix, so this will have to be
> > folded in:
> >
> > diff --git a/block/bdev.c b/block/bdev.c
> > index 2a035be7f3ee90..a20263fa27a462 100644
> > --- a/block/bdev.c
> > +++ b/block/bdev.c
> > @@ -967,7 +967,7 @@ void bdev_mark_dead(struct block_device *bdev, bool surprise)
> >
> > invalidate_bdev(bdev);
> > }
> > -#ifdef CONFIG_DASD
> > +#ifdef CONFIG_DASD_MODULE
>
> This needs to be
>
> #if IS_ENABLED(CONFIG_DASD)
>
> to cover both CONFIG_DASD=y and CONFIG_DASD=m.
Sure, but if DASD is built-in, the symbol doesn't need to be exported
Reply to: