Re: [PATCH 8/9] bcache: use the default discard granularity
- To: Christoph Hellwig <hch@lst.de>
- Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Josef Bacik <josef@toxicpanda.com>, Minchan Kim <minchan@kernel.org>, Sergey Senozhatsky <senozhatsky@chromium.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org
- Subject: Re: [PATCH 8/9] bcache: use the default discard granularity
- From: Coly Li <colyli@suse.de>
- Date: Fri, 5 Jan 2024 15:03:34 +0800
- Message-id: <[🔎] bgbp5rqbxbghiitjvpkuforocw5ptyuubfwwrwdhqy4orkpggo@fu57au3f2hss>
- In-reply-to: <20231228075545.362768-9-hch@lst.de>
- References: <20231228075545.362768-1-hch@lst.de> <20231228075545.362768-9-hch@lst.de>
On Thu, Dec 28, 2023 at 07:55:44AM +0000, Christoph Hellwig wrote:
> The discard granularity now defaults to a single sector, so don't set
> that value explicitly.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Coly Li <colyli@suse.de>
Thanks.
> ---
> drivers/md/bcache/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index ecc1447f202a42..39ec95b8613f1f 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -954,7 +954,6 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
> q->limits.max_segment_size = UINT_MAX;
> q->limits.max_segments = BIO_MAX_VECS;
> blk_queue_max_discard_sectors(q, UINT_MAX);
> - q->limits.discard_granularity = block_size;
> q->limits.io_min = block_size;
> q->limits.logical_block_size = block_size;
> q->limits.physical_block_size = block_size;
> --
> 2.39.2
>
>
--
Coly Li
Reply to: