Bug#724539: RFS: psocksxx/0.0.1-1 [ITP]

[Tobias Frost <tobi@frost.de>]

Hallo Uditha,

(I'm not a DD/DM... Also quite new to reviewing)

Thanks for your work, however there is already a iostream based socket
library in Debian: libskstream. So maybe you can elaborate a little why
you think this library is a must in Debian :) (like reverse
dependencies...)

The package itself looks quite good, just a few remarks (I did not build
the package, just a paper-review)

d/control you libpsocksxx0 Provides: libpsocksxx. I think that is wrong,
as the so-name will be important when installing the library later. (But
I could be wrong here)

I think it is depreciated to install *.la files. 

You should enable multiarch-support

Maybe you'd like also to provide a -doc package with the generated
doxygen documentation. 

Please be aware: Buildd's do not have necessarily have networking, not
even lo is guaranteed. So you might want to disable (parts of) your
testsuite which relies on networking

Best regards,
coldtobi


Am Dienstag, den 24.09.2013, 23:01 +0100 schrieb Uditha Atukorala:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "psocksxx"
> 
> * Package name    : psocksxx
> Version         : 0.0.1-1
> Upstream Author : Uditha Atukorala
> * URL             : https://github.com/uditha-atukorala/psocksxx
> * License         : LGPLv3+
> Section         : libs
> 
> It builds those binary packages:
> 
> libpsocksxx0 - C++ wrapper library for POSIX sockets
> libpsocksxx0-dev - C++ wrapper library for POSIX sockets (development)
> 
> To access further information about this package, please visit the
> following URL:
> http://mentors.debian.net/package/psocksxx
> 
> Alternatively, one can download the package with dget using this command:
> dget -x http://mentors.debian.net/debian/pool/main/p/psocksxx/psocksxx_0.0.1-1.dsc
> 
> More information about psocksxx can be obtained from
> https://github.com/uditha-atukorala/psocksxx.
> 
> There are two lintian messages shown when run with "-I
> --show-overrides --pedantic";
> 1. no-upstream-changelog - this is due to upstream not having a
> changelog file for this version.
> 2. no-symbols-control-file - this is a little tricky to have because
> of c++ (STL) version differences and I can't see one .symbols file
> being valid for all the distributions.
> 
> Regards,
> Uditha Atukorala (Udi)
> 
>