Hi Cédric, On Mon, Apr 14, 2014 at 2:04 PM, Cédric Barboiron <ced@winkie.fr> wrote: > Hi Vincent and Markus, > > Thanks for your comments on the package. > > I've updated the package with copyright information for > - src/compat/gnu_strftime.c (LGPL-2+) > - src/compat/inet_aton.c (GPL-2+ and BSD-4-clause and BSD-3-clause, with > comment for the University of California BSD-4-clause portion) > > As well as the following files (different authors): > - src/match.c (public domain) > - src/compat/snprintf.c (GPL-2+) > - src/md5/md5c.c (public domain) > - scripts/dccwhois.tcl (GPL-2+) > > Finally, I've excluded the only two files with no license information > from the package : scripts/autobotchk and scripts/sentinel.tcl > > You can find the updated package at the same place > http://mentors.debian.net/package/eggdrop > http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-1.dsc > > A quick note on the remaining open bugs: > - #282437 wasn't able to reproduce (but since it is almost 10 years > old...) > - #596641 the UTF-8 patch indeed is simple, but it is labeled as "I want > Eggdrop to speak and understand UTF-8. I want it so badly that I'm > willing to take the ugliest hack available!" on > http://eggwiki.org/Main_Page . It comes from > http://forum.egghelp.org/viewtopic.php?p=82111#82111 , with the > following comment : "BE AWARE: This patch FORCES UTF-8 support, so > only apply it if your system supports it :) [This patch overrides > eggdrops own mechanism to detect the encoding system it should use > based on variables (LC_ALL,...). So this is totally a HACK and > nothing to put into production code for compatibility reasons]" > - #374568 for the same reasons as > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=374568#17 > - Your package FTBFS with pbuilder (full build log attached): checking for Tcl library... not found checking for Tcl header... found /usr/include/tcl8.5/tcl.h checking whether the Tcl system has changed... yes configure: error: Tcl cannot be found on this system. Eggdrop requires Tcl and the Tcl development files to compile. If you already have Tcl installed on this system, make sure you also have the development files (common package names include 'tcl-dev' and 'tcl-devel'). If I just wasn't looking in the right place for it, re-run ./configure using the --with-tcllib='/path/to/libtcl.so' and --with-tclinc='/path/to/tcl.h' options. See doc/COMPILE-GUIDE's 'Tcl Detection and Installation' section for more information. - According to debian/changelog, eggdrop was split into two separate binary packages (an additional -data package) as of 1.6.16-3, so as per Policy 7.6.1 [1], consider adding "Breaks: eggdrop (<< 1.6.16-3)" and "Replaces: eggdrop (<< 1.6.16-3)" relationships to your eggdrop-data binary package, otherwise dpkg will error out on updates from eggdrop << 1.6.16-3 to the current eggdrop package. This would usually qualify as a RC bug, but since 1.6.16-3 was released about 10 years ago, you could possibly get away with not doing this (I don't think piuparts.debian.org tests package upgrades from 10 years back...) - debian/copyright: please give src/rfc1459.c some kind of license name on line 40. Also, the current header in that file isn't really a license...if at all possible, I'd suggest adding the license of the corresponding source file from ircd-hybrid into debian/copyright. Regards, Vincent [1] https://www.debian.org/doc/debian-policy/ch-relationships.html
Attachment:
eggdrop_1.6.21-1_amd64.build
Description: Binary data