Hi,
Thanks for taking care of ArgyllCMS! Here's a quick review.
On Sun, 14 Sep 2014 11:11:43 +0200, Jörg Frings-Fürst
<debian@jff-webhosting.net> wrote:
> * New Maintainer (Closes: #720178).
> * New upstream release (Closes: #742658).
> * debian/rules:
> - Add get-orig-source.
> - Remove useless --with quilt from dh $@
> - Enable hardening=+all
But the line is commented out in debian/rules!
> - Remove section for not included spyder2 firmware.
> - Rewrite for use of upstream build system.
> * debian/control:
> - Set myself as maintainer.
> - Update Build-Depends:
> + Remove automake | automaken
> - For previously not existing Vcs
> + Create a new git repository on alioth.
> + Add the fields Vcs-Browser and Vcs-Git.
> - Change Priority from optional to extra.
> - Remove useless packages:
> + icc-utils
> Now in argyll. Now only dummy package.
Please mention "(transitional package)" in the package's short description,
and perhaps also in the long description ("This package is a transitional
dummy package." instead of "This package is a dummy package.")
> + libicc2 & libicc-dev
> Useless. Only linked to argyll & icc-utils.
> + libimdi0 & libimdi-dev
> Useless. Only linked to argyll & icc-utils.
> * Add debian/source/options:
> - Set compression to xz & compression-level to 9 to save space.
xz is now the default, and 9 is too expensive at decompression-time for some
of the smaller devices where argyll can be useful (think of small ARM boards
driving televisions). It might be better just to remove debian/source/options
entirely...
> * debian/copyright:
> - Rewrite into DEP-5 format.
> - Add myself to the list of authors for debian/*.
> - Add missing licenses and authors.
A few comments on debian/copyright:
* "Aladdin Enterprices" should be "Aladdin Enterprises"
* usb/driver/* should be "License: GPL-2 or LGPL-2" since the licenses aren't
cumulative
* "Richaerd Hughes" should be "Richard Hughes"
* you could say "License: libjpeg" instead of "License: other" for jpg/*
> * debian/*.1
> - Move to debian/man/*.1.
> * debian/man/*
> - Rewrite the help2man generated man pages (Closes: #670857)
> * debian/patches/
> - New 110_dispwin_segfault.patch to prevent segfault by
> wrong parameter (Closes: #700253)
I see other patches as well... 15_jam.patch.org should be removed, along
with the various patches which are no longer used in the series file (and
you should clean up the series file too). In 110_dispwin_segfault.patch, is
there a link to the mailing list archives you could copy in the "Forwarded"
item?
Regards,
Stephen
Attachment:
signature.asc
Description: PGP signature