[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#900407: RFS: odp-dpdk/1.19.0.0-1 [ITP]



control: tag -1 +moreinfo
control: owner -1 !

Hi Dmitry,

Thank you for the package. It looks good except for several flaws:

1. error in postrm script, which causes error on removal

  update-alternatives: error: alternative name (/usr/lib/x86_64-linux-gnu/libodp-linux.so.119) must not contain '/' and spaces
  dpkg: error processing package libodp-dpdk119:amd64 (--remove):
   installed libodp-dpdk119:amd64 package pre-removal script subprocess returned error exit status 2
  Errors were encountered while processing:
   libodp-dpdk119:amd64

2. the alternatives priority of the .so file and .so.119 file should be
   the same.

3. Similar to src:odp, the copyright file of odp-dpdk is not complete:

   grep -ri copyright | grep -vi linaro | grep -i copyright

Apart from that, I have to ask a few questions about this package:

>From README.DPDK
> DPDK only works on a selected range of network cards.

11. Does it support any open-sourced/free network card, which doesn't
    require binary blobs? If it does not support open-sourced/free
	hardwares, which means non-free drivers are indirectly required
	by this package. In this case I'd suggest this package go to
	contrib section instead of main.

	-Section: libs
	+Section: contrib/libs

12. This implementation is specifically optimized for several architectures.
    Does that mean this implementation leverages specific instruction sets,
	e.g. NEON (arm), AVX (amd64), VSX (ppc)?


Reply to: