[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1034282: RFS: ukui-app-widget/1.0.1-1 [ITP] -- ukui app widget test



Hi, Boyuan,

Sorry for this rookie, stupid mistake, Bowen only checked the results of 'lintian' and 'licensecheck -r' when reviewing the package, not the other parts, including the incorrect copyright statement.
And I also confirmed the problem with the upstream author, when she took over the code, the headers of some files in QtSingleApplication have been accidentally blanked out, and she added the company's copyrights without checking in order to deal with the "No copyright Unknow"  warnings. 
The problem has been fixed upstream, and we'll improve the guidebook and training to avoid this kind of problem from occurring again.

> Your package embeds multiple copies of QtSimpleApplication. This is not a good
> practice at all. Can you work with upstream to only include one copy?
This is fixed upstream.

> Besides, I don't understand upstream commit 2e15e13. Can you explain why you
> revert version 4.x to 1.0.1?
Yes, It's no need to revert version 4.x to 1.0.1, we will upload the fixed version to mentors later.

Regards,
handsome_feng


Reply to: