[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1057098: RFS: runit/2.1.2-57 -- system-wide service supervision



Control: tags -1 -moreinfo

Hi Tobi,
thanks for having a look at this package :)
Uploaded again to mentors with the following changes:
 - removed message in preinst (no longer useful, see below)
 - cleaned up obsolete lintian tag to avoid a new lintian error

new links:

https://mentors.debian.net/package/runit/

dget -x
https://mentors.debian.net/debian/pool/main/r/runit/runit_2.1.2-57.dsc

Git repo (updated):
  https://salsa.debian.org/debian/runit/-/tree/next?ref_type=heads


> There is a lintian warning:
> W debian-news-entry-has-unknown-version
> 2.1.2-14 [usr/share/doc/getty-run/NEWS.Debian.gz:1]

this was fixed in Debhelper [1], now the NEWS file is automatically
trimmed

> the warning of unmerged systems will stop booting soon MUST
> be in Debian.NEWS, preinst is the wrong place and it will be
> very likely missed.  NEWS is a well-known mechanism to convey
> important information. 
> 
> On the other hand, is this warning acutally required?  Once this will
> get a real issue, Depend: on usr-is-merged and you should
> be set. If you cannot tell when that is, enforce it now, as non-merged
> systems are no longer supported anyway. 
> 

The message was targeted downstream (especially Devuan) where the merged
layout is not enforced but no plan was made to actively support unmerged
layout. A relevant share of users in testing/unstable where running with
the system not merged with no clue that the system was about to break.

The problem with the NEWS file is that people don't have apt-listchanges
installed and also the NEWS can't be displayed conditionally (only to
unmerged systems).

The message is already in runit_2.1.2-54+usrmerge (unstable/testing)
and subsequently a long discussion started both on Devuan-users mailing
list and the Devuan forum, so users are no longer unaware of the issue
and I'm satisfied with that.
(unmerged systems are already broken now so the message is no longer
useful)


> 
> TL:DR: init-system-helpers is Essential: Yes, so you can already now
> Depend: on usr-is-merged if you want to make sure.
> (That will also cover where people held init-systems-helpers to an
> older
> 

I prefer if this is dealt at distro level (downstream), so they either
provide support for unmerged layout or they enforce the merge.

Best Regards,
Lorenzo

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=%231021607


Reply to: