[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1064344: RFS: vzlogger/0.8.3 ITP #864255



Control: tags -moreinfo

Hi Tobias.

Thanks for looking into the package.

Am Donnerstag, dem 22.02.2024 um 22:58 +0100 schrieb Tobias Frost:
> d/source/lintian-overrides
>  - delete the overrides, seems to be some remnant of earlier packaging.
> 
> d/DEBIAN_RELEASE.txt
>  - delete this file; the information contained in this files would not
>    be a process how to create a package for Debian. (and if you need a
>    file describing certain unusal aspects of the Debian packaging, it
>    would be README.source (see Debian Policy §4.14)
>    I recommend checking out git-buildpackage:
>    https://honk.sigxcpu.org/piki/projects/git-buildpackage/ 
>    https://honk.sigxcpu.org/projects/git-buildpackage/manual-html/
>    - remove Debian_release.patch -- this is not needed, you work with
>    your debian/ directory and evolve it, you do not patch it when you
>    create a new version. 
> 
> d/control
>  - specify Rules-Require-Root
>  - you manually depend on libsml1. Can you expand why this is needed?
>  - Build-Depend: s/pkg-config/pkgconf
>  - remove versions from the versioned build dependencies, if the
>    debpendency is already fulfilled in oldstable:
>    - libjson-c-dev, libcurl4-openssl-dev, 
> 
> 
> d/postinst / postrm
>  - When you create a user, it should start with "_" - see policy 9.2.1
>    - Another option might be using systemd's DynamicUser feature to 
>      create the user at runtime. (bonus: some hardening for free.)
>    - there's systemd-sysuser (works also without systemd as init system)
>      to use sysusers.d 
>    - do not delete users/groups on package removal. 

All changes have been done. In addition the repository has been moved
to DEP-14 layout.

Sincerely,
Joachim


Reply to: