Debian Bug report logs - #13381
fileutils: df shows crazy numbers for minix fs

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joey@kite.ml.org>

To: submit@bugs.debian.org

Subject: fileutils: df shows crazy numbers for minix fs

Date: 26 Sep 1997 17:00:37 -0000

Package: fileutils
Version: 3.16-5

I have a 720k floppy mounted. It was formatted with the minix filesystem on
a minux 2.0.0 machine. I can read and write files from it fine, I don't see
any kernel error messages. 

Df says:

/dev/fd0              701K -7489.0K   8.0M  -1067%   /mnt/a

-- System Information
Debian Release: 1.3
Kernel Version: Linux kite 2.0.29 #1 Fri Sep 12 19:55:38 EDT 1997 i586 unknown

Versions of the packages fileutils depends on:
libc6	Version: 2.0.4-1

Message #10 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Galen Hazelwood <galenh@micron.net>

To: Joey Hess <joey@kite.ml.org>, 13381@bugs.debian.org

Subject: Re: Bug#13381: fileutils: df shows crazy numbers for minix fs

Date: Tue, 07 Oct 1997 11:48:32 -0600

Joey Hess wrote:

> Package: fileutils
> Version: 3.16-5
>
> I have a 720k floppy mounted. It was formatted with the minix filesystem on
> a minux 2.0.0 machine. I can read and write files from it fine, I don't see
> any kernel error messages.

Are you sure df is giving you crazy numbers...or is it merely correctly passing
on the crazy numbers it gets from the kernel?

If the latter, there's nothing I can do.

--Galen

Message #15 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joey@kite.ml.org>

To: Galen Hazelwood <galenh@micron.net>

Cc: 13381@bugs.debian.org

Subject: Re: Bug#13381: fileutils: df shows crazy numbers for minix fs

Date: Tue, 7 Oct 1997 14:12:56 -0400

Galen Hazelwood wrote:
> Are you sure df is giving you crazy numbers...or is it merely correctly passing
> on the crazy numbers it gets from the kernel?

Probably the latter.
 
> If the latter, there's nothing I can do.

Well you could forward the bug to the kernel.

-- 
see shy jo

Message #20 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Galen Hazelwood <galenh@micron.net>

To: Joey Hess <joey@kite.ml.org>

Cc: 13381@bugs.debian.org

Subject: Re: Bug#13381: fileutils: df shows crazy numbers for minix fs

Date: Tue, 07 Oct 1997 12:18:24 -0600

Joey Hess wrote:

> Galen Hazelwood wrote:
> > Are you sure df is giving you crazy numbers...or is it merely correctly passing
> > on the crazy numbers it gets from the kernel?
>
> Probably the latter.

Thought so.  Is there any way you can tell for sure?


> > If the latter, there's nothing I can do.
>
> Well you could forward the bug to the kernel.

Well, yes, I could.  What I _meant_ was that there's nothing I can do with df to
make things work... :)

--Galen

Message #25 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joey@kite.ml.org>

To: Galen Hazelwood <galenh@micron.net>

Cc: 13381@bugs.debian.org

Subject: Re: Bug#13381: fileutils: df shows crazy numbers for minix fs

Date: Tue, 7 Oct 1997 14:22:11 -0400

Galen Hazelwood wrote:
> Joey Hess wrote:
> 
> > Galen Hazelwood wrote:
> > > Are you sure df is giving you crazy numbers...or is it merely correctly passing
> > > on the crazy numbers it gets from the kernel?
> >
> > Probably the latter.
> 
> Thought so.  Is there any way you can tell for sure?

Well, I don't know. I don't really know how the amount of free space is
determined, in the first place. If you have any ideas, I'll be happy to try
them. I can even send you a disk image that will reproduce it, I think.

-- 
see shy jo

Message #30 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Galen Hazelwood <galenh@micron.net>

To: Joey Hess <joey@kite.ml.org>

Cc: 13381@bugs.debian.org

Subject: Re: Bug#13381: fileutils: df shows crazy numbers for minix fs

Date: Tue, 07 Oct 1997 16:34:45 -0600

Joey Hess wrote:

> > Thought so.  Is there any way you can tell for sure?
>
> Well, I don't know. I don't really know how the amount of free space is
> determined, in the first place. If you have any ideas, I'll be happy to try
> them. I can even send you a disk image that will reproduce it, I think.

The code for determining the amount of free space is in fileutils-3.16/lib/fsusage.c.
It seems to use the statfs function, defined in sys/statfs.h.

What you could do is write a stupid little c program, which only calls statfs, and then
dumps the result, unprocessed.  If those numbers look right, then df is mangling the
data.  If not, the minix filesystem code is giving you mangled data.  We now know where
the bug is!

For reference, "struct statfs" is defined in statfsbuf.h.

--Galen

Message #35 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Galen Hazelwood <galenh@micron.net>

To: Joey Hess <joey@kite.ml.org>, 13381@bugs.debian.org

Subject: Re: Bug#13381: fileutils: df shows crazy numbers for minix fs

Date: Tue, 07 Oct 1997 17:17:27 -0600

Joey Hess wrote:

> Galen Hazelwood wrote:
> > The code for determining the amount of free space is in fileutils-3.16/lib/fsusage.c.
> > It seems to use the statfs function, defined in sys/statfs.h.
> > What you could do is write a stupid little c program, which only calls statfs
>
> Ok, I did so. The program seems to give sane results for my root filesystem:
>
> joey@kite:/tmp>./statdumper
> f_type = ef53
> f_bsize = 1024
> f_blocks = 198123
> f_bfree = 63941
> f_bavail = 53710
> f_files = 51200
> f_ffree = 48723
>
> joey@kite:/tmp>df /
> Filesystem         1024-blocks  Used Available Capacity Mounted on
> /dev/hda2             198123  134182    53710     71%   /
>
> And here are the results for the weird minix floppy:
>
> joey@kite:/tmp>./statdumper
> f_type = 2468
> f_bsize = 1024
> f_blocks = 701
> f_bfree = 8081
> f_bavail = 8081
> f_files = 240
> f_ffree = 8188
>
> joey@kite:/tmp>df /mnt/a
> Filesystem         1024-blocks  Used Available Capacity Mounted on
> /dev/fd0                 701   -7380     8081  -1052%   /mnt/a
>
> And the numbers again match up. f_blocks=701, and yet f_bfree=8081, which is
> obviously wrong.. So you can reassign this to the kernel or wherever else you
> think is appropriate.

Yep, most definitely wrong.  You say this disk was formatted under minix 2.0?  That's
fairly recent, right?  Perhaps the superblock format has changed subtly.  The old minix
filesystem code probably wouldn't have incorporated recent changes.

What package do you think I should reassign it to?  kernel-source-2.0.30?

--Galen

Message #40 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Herbert Xu <herbert@gondor.apana.org.au>

To: Joey Hess <joey@kite.ml.org>, 13381@bugs.debian.org

Subject: Re: Bug#13381: fileutils: df shows crazy numbers for minix fs

Date: Wed, 08 Oct 1997 19:39:15 +1000

Joey Hess wrote:
> 
> Well, I don't know. I don't really know how the amount of free space is
> determined, in the first place. If you have any ideas, I'll be happy to try
> them. I can even send you a disk image that will reproduce it, I think.

strace it.
-- 
Debian GNU/Linux 1.3 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://greathan.apana.org.au/~herbert/
PGP Key: http://greathan.apana.org.au/~herbert/pubkey.txt

Message #47 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Herbert Xu <herbert@gondor.apana.org.au>

To: joey@kite.ml.org

Cc: 13381@bugs.debian.org

Subject: disk image

Date: Thu, 9 Oct 1997 19:40:05 +1000 (EST)

Hi:
	Can you make the disk image available over the net so I can take a look
at it? Thanks.
-- 
Debian GNU/Linux 1.3 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://greathan.apana.org.au/~herbert/
PGP Key: http://greathan.apana.org.au/~herbert/pubkey.txt

Message #52 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Herbert Xu <herbert@gondor.apana.org.au>

To: joey@kite.ml.org (Joey Hess)

Cc: 13381@bugs.debian.org

Subject: Re: disk image

Date: Tue, 9 Dec 1997 11:22:47 +1100 (EST)

Joey Hess wrote:
> 
> It's ralatively small, so I took the librerty of attaching it to this
> message.

Sorry for the long delay in processing this bug.  But could you check whether
this occurs with the latest 2.1 kernel? It looks there is support for Minix V2
fs there.  Thanks.

-- 
Debian GNU/Linux 1.3 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://greathan.apana.org.au/~herbert/
PGP Key: http://greathan.apana.org.au/~herbert/pubkey.txt

Message #57 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Herbert Xu <herbert@gondor.apana.org.au>

To: joey@kitenet.net (Joey Hess)

Cc: 13381@bugs.debian.org

Subject: Re: disk image

Date: Tue, 9 Dec 1997 13:45:17 +1100 (EST)

Joey Hess wrote:
> 
> Do you mean the literally latest kernel, or is 2.1.65 ok?

That will do.

-- 
Debian GNU/Linux 1.3 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://greathan.apana.org.au/~herbert/
PGP Key: http://greathan.apana.org.au/~herbert/pubkey.txt

Message #62 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Herbert Xu <herbert@gondor.apana.org.au>

To: 13381@bugs.debian.org

Subject: Re: disk image (fwd)

Date: Thu, 11 Dec 1997 10:55:51 +1100 (EST)

----- Forwarded message from Joey Hess -----

From joey@kitenet.net  Tue Dec  9 13:06:14 1997
Received: from kitenet.net (qmailr@kitenet.net [206.228.243.193])
	by gondor.apana.org.au (8.8.8/8.8.8/Debian/GNU) with SMTP id NAA26403
	for <herbert@gondor.apana.org.au>; Tue, 9 Dec 1997 13:06:10 +1100
Received: (qmail 31021 invoked by uid 500); 9 Dec 1997 02:06:02 -0000
Message-ID: <19971208210602.60688@kite>
Date: Mon, 8 Dec 1997 21:06:02 -0500
From: Joey Hess <joey@kitenet.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: disk image
References: <19971009123605.46895@kite> <199712090022.LAA26215@gondor.apana.org.au>
X-Mailer: Mutt 0.88
In-Reply-To: <199712090022.LAA26215@gondor.apana.org.au>; from Herbert Xu on Tue, Dec 09, 1997 at 11:22:47AM +1100

Herbert Xu wrote:
> Joey Hess wrote:
> > 
> > It's ralatively small, so I took the librerty of attaching it to this
> > message.
> 
> Sorry for the long delay in processing this bug.  But could you check whether
> this occurs with the latest 2.1 kernel? It looks there is support for Minix V2
> fs there.  Thanks.

It's still broken in 2.1.65. I'll test 2.1.71 later, I haven't had much luck
getting that kernel to work yet..

-- 
see shy jo

----- End of forwarded message from Joey Hess -----

-- 
Debian GNU/Linux 1.3 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://greathan.apana.org.au/~herbert/
PGP Key: http://greathan.apana.org.au/~herbert/pubkey.txt

Message #65 received at 13381-forwarded@bugs.debian.org (full text, mbox, reply):

From: Herbert Xu <herbert@gondor.apana.org.au>

To: linux-kernel@vger.rutgers.edu

Cc: 13381-forwarded@bugs.debian.org, joey@kite.ml.org

Subject: statfs patch for minix v2 fs

Date: Thu, 11 Dec 1997 11:03:38 +1100 (EST)

Hi:
	The statfs for minix implementation in 2.1.72 is buggy.  It needs the
following patch to give the correct count.  For a disk image that demonstrates
the problem, please check out

	http://greathan.apana.org.au/~herbert/kernel/miniximage.gz

You might also want to read the stuff at

	http://www.debian.org/Bugs/db/13/13381.html

-- 
Debian GNU/Linux 1.3 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://greathan.apana.org.au/~herbert/
PGP Key: http://greathan.apana.org.au/~herbert/pubkey.txt
--
--- linux/fs/minix/bitmap.c.orig	Wed Dec 10 22:16:50 1997
+++ linux/fs/minix/bitmap.c	Thu Dec 11 08:25:57 1997
@@ -21,17 +21,31 @@
 
 static int nibblemap[] = { 4,3,3,2,3,2,2,1,3,2,2,1,2,1,1,0 };
 
-static unsigned long count_free(struct buffer_head *map[], unsigned numblocks)
+static unsigned long count_free(struct buffer_head *map[], unsigned numblocks, __u32 numbits)
 {
 	unsigned i, j, sum = 0;
 	struct buffer_head *bh;
   
-	for (i=0; i<numblocks; i++) {
+	for (i=0; i<numblocks-1; i++) {
 		if (!(bh=map[i])) 
 			return(0);
 		for (j=0; j<BLOCK_SIZE; j++)
-			sum += nibblemap[bh->b_data[j] & 0xf] 
-				+ nibblemap[(bh->b_data[j]>>4)&0xf];
+			sum += nibblemap[bh->b_data[j] & 0xf]
+				+ nibblemap[(bh->b_data[j]>>4) & 0xf];
+	}
+
+	if (numblocks==0 || !(bh=map[numblocks-1]))
+		return(0);
+	i = (numbits-(numblocks-1)*BLOCK_SIZE*8)/8;
+	for (j=0; j<i; j++) {
+		sum += nibblemap[bh->b_data[j] & 0xf]
+			+ nibblemap[(bh->b_data[j]>>4) & 0xf];
+	}
+
+	i = numbits%8;
+	if (i!=0) {
+		i = bh->b_data[j] | ~((1<<i) - 1);
+		sum += nibblemap[i & 0xf] + nibblemap[(i>>4) & 0xf];
 	}
 	return(sum);
 }
@@ -108,8 +122,9 @@
 
 unsigned long minix_count_free_blocks(struct super_block *sb)
 {
-	return (count_free(sb->u.minix_sb.s_zmap,sb->u.minix_sb.s_zmap_blocks)
-		 << sb->u.minix_sb.s_log_zone_size);
+	return (count_free(sb->u.minix_sb.s_zmap, sb->u.minix_sb.s_zmap_blocks,
+		sb->u.minix_sb.s_nzones - sb->u.minix_sb.s_firstdatazone + 1)
+		<< sb->u.minix_sb.s_log_zone_size);
 }
 
 static struct buffer_head *V1_minix_clear_inode(struct inode *inode)
@@ -266,5 +281,6 @@
 
 unsigned long minix_count_free_inodes(struct super_block *sb)
 {
-	return count_free(sb->u.minix_sb.s_imap,sb->u.minix_sb.s_imap_blocks);
+	return count_free(sb->u.minix_sb.s_imap, sb->u.minix_sb.s_imap_blocks,
+		sb->u.minix_sb.s_ninodes + 1);
 }

Message #66 received at 13381-forwarded@bugs.debian.org (full text, mbox, reply):

From: owner@bugs.debian.org (Ian Jackson)

To: 13381-forwarded@bugs.debian.org, joey@kite.ml.org, herbert@debian.org

Cc: Herbert Xu <herbert@debian.org>

Subject: Bug#13381: marked as forwarded (fileutils: df shows crazy numbers for minix fs)

Date: Wed, 10 Dec 97 18:03 CST

Your message dated Thu, 11 Dec 1997 11:03:38 +1100 (EST)
with message-id <199712110003.LAA24560@gondor.apana.org.au>
and subject line statfs patch for minix v2 fs
has caused the Debian bug report #13381,
regarding fileutils: df shows crazy numbers for minix fs
to be marked as having been forwarded to the upstream software
author(s) linux-kernel@vger.rutgers.edu.

(NB: If you are a system administrator and have no idea what I'm
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Ian Jackson
(maintainer, Debian bug tracking system)

Received: (at submit) by bugs.debian.org; 26 Sep 1997 16:59:13 +0000
Received: (qmail 7110 invoked from network); 26 Sep 1997 16:59:11 -0000
Received: from kite.ml.org (qmailr@kite.ml.org@206.228.243.193)
  by 205.229.104.5 with SMTP; 26 Sep 1997 16:59:11 -0000
Received: (qmail 2786 invoked by uid 500); 26 Sep 1997 17:00:37 -0000
Date: 26 Sep 1997 17:00:37 -0000
Message-ID: <19970926170037.2785.qmail@kite.ml.org>
From: Joey Hess <joey@kite.ml.org>
Subject: fileutils: df shows crazy numbers for minix fs
To: submit@bugs.debian.org
X-Mailer: bug 2.95

Package: fileutils
Version: 3.16-5

I have a 720k floppy mounted. It was formatted with the minix filesystem on
a minux 2.0.0 machine. I can read and write files from it fine, I don't see
any kernel error messages. 

Df says:

/dev/fd0              701K -7489.0K   8.0M  -1067%   /mnt/a

-- System Information
Debian Release: 1.3
Kernel Version: Linux kite 2.0.29 #1 Fri Sep 12 19:55:38 EDT 1997 i586 unknown

Versions of the packages fileutils depends on:
libc6	Version: 2.0.4-1

Message #67 received at 13381-forwarded@bugs.debian.org (full text, mbox, reply):

From: Pavel Fidrmuc <dajinka@atrey.karlin.mff.cuni.cz>

To: Herbert Xu <herbert@gondor.apana.org.au>

Cc: linux-kernel@vger.rutgers.edu, 13381-forwarded@bugs.debian.org, joey@kite.ml.org

Subject: Re: statfs patch for minix v2 fs

Date: Tue, 16 Dec 1997 16:12:01 +0100 (MET)

LOGOUT CONFERENCE!!!!!!!!!!!!!> 

                                     Pajik

Message #72 received at 13381@bugs.debian.org (full text, mbox, reply):

From: Herbert Xu <herbert@gondor.apana.org.au>

To: 13381@bugs.debian.org

Subject: Fixed in 2.1.74

Date: Sun, 21 Dec 1997 09:24:43 +1100 (EST)

This bug has been fixed in 2.1.74.  I'll leave it open until we move to 2.2.
-- 
Debian GNU/Linux 1.3 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Message #81 received at 13381-done@bugs.debian.org (full text, mbox, reply):

From: Herbert Xu <herbert@gondor.apana.org.au>

To: 13381-done@bugs.debian.org

Subject: 2.2 is now in the distro

Date: Sat, 25 Sep 1999 19:43:43 +1000

Since potato has 2.2, I'm closing bug.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Send a report that this bug log contains spam.