[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#867361: sitesummary: Fix autopkgtest to work in environments with http_proxy set



Package: sitesummary
Version: 0.1.28
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu artful ubuntu-patch

Dear maintainers,

Thanks for the work on improving the autopkgtest for sitesummary in recent
uploads.

In Ubuntu, sitesummary has been stuck at version 0.1.21 because this is the
last version of the package with an autopkgtest that didn't confirm the
results on disk; and the autopkgtest does not actually correctly test
sitesummary in an Ubuntu environment because http_proxy is set on our test
runners and so the test case is talking to a squid proxy instead of to the
local apache.

I have just uploaded the attached patch to Ubuntu, which should make the
autopkgtest work in the face of http_proxy (results will soon be visible at
http://autopkgtest.ubuntu.com/packages/s/sitesummary/artful/amd64).

Please consider including the patch in Debian as well.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org
diff -Nru sitesummary-0.1.28/debian/tests/test-server-client sitesummary-0.1.28ubuntu1/debian/tests/test-server-client
--- sitesummary-0.1.28/debian/tests/test-server-client	2017-01-07 04:36:53.000000000 -0800
+++ sitesummary-0.1.28ubuntu1/debian/tests/test-server-client	2017-07-05 16:56:28.000000000 -0700
@@ -14,6 +14,8 @@
 LC_ALL=C
 export LC_ALL
 
+unset http_proxy
+
 # Installing the binary packages should set up apache on localhost and
 # the cgi script for the sitesummary collector.  But some times the
 # install does not do this, because the apt system is sorting the

Reply to: