[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1014156: lintian: very-long-line-length-in-source-file for non-text source files



On 01/07/2022 06:08, Daniel Kahn Gillmor wrote:
Package: lintian
Version: 2.115.2
Severity: minior
Control: affects -1 src:gnupg2

lintian 2.115.2 complains (in --pedantic) in the following way about
these non-text files in the gnupg2 sources:

P: gnupg2 source: very-long-line-length-in-source-file 1008 > 512 [po/eo.gmo:7]
P: gnupg2 source: very-long-line-length-in-source-file 1092 > 512 [po/hu.gmo:14]
P: gnupg2 source: very-long-line-length-in-source-file 1128 > 512 [po/id.gmo:10]
P: gnupg2 source: very-long-line-length-in-source-file 1240 > 512 [po/pt.gmo:12]
P: gnupg2 source: very-long-line-length-in-source-file 1372 > 512 [po/fi.gmo:14]
P: gnupg2 source: very-long-line-length-in-source-file 1488 > 512 [po/sk.gmo:7]
P: gnupg2 source: very-long-line-length-in-source-file 1544 > 512 [po/ca.gmo:15]
P: gnupg2 source: very-long-line-length-in-source-file 1555 > 512 [g10/t-keydb-get-keyblock.gpg:1091]
P: gnupg2 source: very-long-line-length-in-source-file 1819 > 512 [po/ro.gmo:39]
P: gnupg2 source: very-long-line-length-in-source-file 2016 > 512 [po/et.gmo:14]
P: gnupg2 source: very-long-line-length-in-source-file 2116 > 512 [po/gl.gmo:15]
P: gnupg2 source: very-long-line-length-in-source-file 2832 > 512 [po/el.gmo:11]
P: gnupg2 source: very-long-line-length-in-source-file 2921 > 512 [po/sv.gmo:1671]
P: gnupg2 source: very-long-line-length-in-source-file 3272 > 512 [po/zh_TW.gmo:54]
P: gnupg2 source: very-long-line-length-in-source-file 3508 > 512 [po/da.gmo:62]
P: gnupg2 source: very-long-line-length-in-source-file 3663 > 512 [po/ja.gmo:1530]
P: gnupg2 source: very-long-line-length-in-source-file 3667 > 512 [po/en@boldquot.gmo:1555]
P: gnupg2 source: very-long-line-length-in-source-file 3667 > 512 [po/en@quot.gmo:1550]
P: gnupg2 source: very-long-line-length-in-source-file 3772 > 512 [po/zh_CN.gmo:103]
P: gnupg2 source: very-long-line-length-in-source-file 4054 > 512 [po/cs.gmo:2986]
P: gnupg2 source: very-long-line-length-in-source-file 4227 > 512 [po/de.gmo:3034]
P: gnupg2 source: very-long-line-length-in-source-file 4235 > 512 [po/pl.gmo:3016]
P: gnupg2 source: very-long-line-length-in-source-file 4264 > 512 [po/nb.gmo:83]
P: gnupg2 source: very-long-line-length-in-source-file 4285 > 512 [po/it.gmo:2998]
P: gnupg2 source: very-long-line-length-in-source-file 4324 > 512 [po/fr.gmo:2628]
P: gnupg2 source: very-long-line-length-in-source-file 4344 > 512 [po/ru.gmo:3005]
P: gnupg2 source: very-long-line-length-in-source-file 4564 > 512 [po/uk.gmo:2931]
P: gnupg2 source: very-long-line-length-in-source-file 4628 > 512 [po/tr.gmo:41]
P: gnupg2 source: very-long-line-length-in-source-file 4900 > 512 [po/es.gmo:74]
P: gnupg2 source: very-long-line-length-in-source-file 520 > 512 [tests/gpgsm/cert_dfn_pca15.der:5]
P: gnupg2 source: very-long-line-length-in-source-file 536 > 512 [tests/openpgp/tofu/cross-sigs/871C2247-2.gpg:5]
P: gnupg2 source: very-long-line-length-in-source-file 536 > 512 [tests/openpgp/tofu/cross-sigs/871C2247-3.gpg:7]
P: gnupg2 source: very-long-line-length-in-source-file 536 > 512 [tests/openpgp/tofu/cross-sigs/871C2247-4.gpg:8]
P: gnupg2 source: very-long-line-length-in-source-file 544 > 512 [tests/openpgp/tofu/conflicting/BE04EB2B-secret.gpg:11]
P: gnupg2 source: very-long-line-length-in-source-file 562 > 512 [tests/openpgp/tofu/cross-sigs/EC38277E-1.gpg:3]
P: gnupg2 source: very-long-line-length-in-source-file 562 > 512 [tests/openpgp/tofu/cross-sigs/EC38277E-2.gpg:4]
P: gnupg2 source: very-long-line-length-in-source-file 570 > 512 [tests/openpgp/tofu/conflicting/1C005AF3-secret.gpg:2]
P: gnupg2 source: very-long-line-length-in-source-file 585 > 512 [tests/openpgp/tofu/conflicting/B662E42F.gpg:6]
P: gnupg2 source: very-long-line-length-in-source-file 610 > 512 [tests/openpgp/tofu/cross-sigs/EC38277E-secret.gpg:6]
P: gnupg2 source: very-long-line-length-in-source-file 687 > 512 [tests/openpgp/tofu/conflicting/B662E42F-secret.gpg:8]
P: gnupg2 source: very-long-line-length-in-source-file 692 > 512 [build-aux/speedo/w32/gnupg-logo-150x57.bmp:1]
P: gnupg2 source: very-long-line-length-in-source-file 719 > 512 [g10/t-keydb-keyring.kbx:1]
P: gnupg2 source: very-long-line-length-in-source-file 925 > 512 [build-aux/speedo/w32/gnupg-logo-164x314.bmp:1]

I could add some overrides, but it doesn't really make sense to do so.
I'd prefer it if lintian instead just wouldn't flag non-text source
files with this tag.

We could argue about whether upstream *should* be including non-text
files in source, of course, but there are some not-implausible reasons:

  - some of these files are test vectors (OpenPGP certificates in binary
    form, DER-formatted X.509 certificates, kbx files)

  - some of them are graphics files (gnupg-logo-*.bmp)

  - some of them are GNU message catalogs -- compiled output of .po files
    that upstream prefers to ship in the tarball for folks building the
    package without l10n toolchains.  we rebuild them in debian, but i'd
    still rather ship the upstream tarball if possible.

And i'd rather not try to convince upstream that they should ship a
different tarball.

If there's some way that i need to flag these files as non-text for
lintian's sake, i'm willing to do that, but i don't know how to do it.

           --dkg

Hi,


I'm also seeing this with strawberry. Several hits from binary sound files in it's test suite.

P: strawberry source: very-long-line-length-in-source-file 1147 > 512 [tests/data/audio/strawberry.oga:126]
P: strawberry source: very-long-line-length-in-source-file 1297 > 512 [tests/data/audio/strawberry.wv:101]
P: strawberry source: very-long-line-length-in-source-file 14620 > 512 [tests/data/audio/strawberry.aif:399]
P: strawberry source: very-long-line-length-in-source-file 2139 > 512 [tests/data/audio/strawberry.opus:44]
P: strawberry source: very-long-line-length-in-source-file 2140 > 512 [tests/data/audio/strawberry.m4a:39]
P: strawberry source: very-long-line-length-in-source-file 3435 > 512 [dist/macos/strawberry.icns:5678]
P: strawberry source: very-long-line-length-in-source-file 4235 > 512 [tests/data/audio/strawberry.flac:5]
P: strawberry source: very-long-line-length-in-source-file 5165 > 512 [tests/data/audio/strawberry.asf:68]
P: strawberry source: very-long-line-length-in-source-file 543 > 512 [CMakeLists.txt:535]
P: strawberry source: very-long-line-length-in-source-file 559 > 512 [data/schema/schema-8.sql:587]
P: strawberry source: very-long-line-length-in-source-file 566 > 512 [data/schema/schema-11.sql:235]
P: strawberry source: very-long-line-length-in-source-file 654 > 512 [tests/data/audio/strawberry.spx:48]
P: strawberry source: very-long-line-length-in-source-file 687 > 512 [3rdparty/SPMediaKeyTap/README.md:4]
P: strawberry source: very-long-line-length-in-source-file 756 > 512 [3rdparty/SPMediaKeyTap/LICENSE:8]


Cheers,
Peter


Reply to: