[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1021364: RFS: ghostwriter/2.2.0-1 [RC] -- Distraction-free, themeable Markdown editor



For the 3rdparty/MathJax/bin/* files, there seem to be source files in
3rdparty/MathJax/src/*. Have you tried to build that
3rdparty/MathJax/bin/* directory yourself and have you checked out if
you can replace the whole whing with libjs-mathjax?


it's a bit of a mess, I made changes, in debian/copyright, unfortunately it makes build errors:
*** No rule to make target '3rdparty/MathJax/bin/startup.js', needed by 'build/release/qrc_resources.cpp'.
Stop.
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/build/ghostwriter-2.1.6+dfsg'
dh_auto_build: error: make -j6 returned exit code 2
make: *** [debian/rules:6: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
I: copying local configuration
E: Failed autobuilding of package



 

Le mar. 11 oct. 2022 à 02:44, Wookey <wookey@wookware.org> a écrit :
On 2022-10-10 23:56 +0200, Sebastien Chavaux wrote:
>    Good evening;
>    I set build dependency in debian/control file "node-react" and
>    "libs-mathjax". For now and to test if the package builds well, I removed
>    the 3rdparty/MathJax/ and 3rdparty/react/ sources.  It builds and works
>    well that way. What would be best next, remove those two folders from
>    sources, leave them but ignore them, or whatever?  How should I do the
>    thing?

Either complies with policy.

There is nothing wrong with the 3rdparty stuff from a copyright
POV. However, I prefer to remove it as it often makes a dramatically
smaller source package, and avoids accidental regressions (to using
the embedded copy) in later updates. It's good practice to adjust the
version number to show that the tarball has been repacked from what
upstream released.

Just put 3rdparty into files-excluded: in the debian/copyright file, and setup up the watch file to repack/rename.
https://wiki.debian.org/_javascript_/Repacking
https://wiki.debian.org/UscanEnhancements

Wookey
--
Principal hats:  Debian, Wookware, ARM
http://wookware.org/

Attachment: changelog
Description: Binary data

Attachment: watch
Description: Binary data

Attachment: copyright
Description: Binary data

Attachment: control
Description: Binary data


Reply to: