[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ITS: libtext-string-hexconvert-perl



On Fr, 02 Sep 2022, I wrote:

> Package: libtext-string-hexconvert-perl
> Version: 0.01-2.1
> Severity: important

> I'd like to salvage and take over the package (under the perl team
> umbrella).
> For more information about the salvaging process see 
> https://wiki.debian.org/PackageSalvaging and
> https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#package-salvaging

I now updated the package to upstream version 0.02 and did the
following debian/* changes/updates:

  * New upstream version 0.02.
  * Rename package from libtext-string-hexconvert-perl to
    libstring-hexconvert-perl.
  * Take over unmaintained package (Closes: #1018938, #979504).
  * Add debian/watch file.
  * Update debian/copyright.
  * Add debian/source/format.
  * Update debian/control: New debhelper, Priority optional,
    Standards-Version 4.6.1, updated Homepage, Rules-Requires-Root: no.
  * Add VCS headers to debian/control.
  * Add Testsuite: autopkgtest-pkg-perl.
  * Add CI via debian/salsa-ci.yml.

The main change is the renaming of the source and binary package from
libtext-string-hexconvert-perl to libstring-hexconvert-perl, since
this the canonical name for a Perl moduled named String::HexConvert,
the "text-" part does not make sense here.

I pushed the new package to salsa:
https://salsa.debian.org/perl-team/modules/packages/libstring-hexconvert-perl 
where the salsa pipeline runs without issues and the package is now
lintian clean.

I attached a diff of debian/ directory between 0.01-2.1 and new
0.02-1, if you are interested in the upstream changes, have a look at
salsa (see above).

I didn't receive any response to the ITS request for 21 days now, so
as the next step I'll upload the package to the DELAYED queue with 7
days delay now.

Greetings
Roland
diff --git a/debian/changelog b/debian/changelog
index 623d674..76c2243 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,20 @@
+libstring-hexconvert-perl (0.02-1) unstable; urgency=medium
+
+  * New upstream version 0.02.
+  * Rename package from libtext-string-hexconvert-perl to
+    libstring-hexconvert-perl.
+  * Take over unmaintained package (Closes: #1018938, #979504).
+  * Add debian/watch file.
+  * Update debian/copyright.
+  * Add debian/source/format.
+  * Update debian/control: New debhelper, Priority optional,
+    Standards-Version 4.6.1, updated Homepage, Rules-Requires-Root: no.
+  * Add VCS headers to debian/control.
+  * Add Testsuite: autopkgtest-pkg-perl.
+  * Add CI via debian/salsa-ci.yml.
+
+ -- Roland Rosenfeld <roland@debian.org>  Fri, 23 Sep 2022 12:50:11 +0200
+
 libtext-string-hexconvert-perl (0.01-2.1) unstable; urgency=medium
 
   * Non maintainer upload by the Reproducible Builds team.
diff --git a/debian/compat b/debian/compat
deleted file mode 100644
index 45a4fb7..0000000
--- a/debian/compat
+++ /dev/null
@@ -1 +0,0 @@
-8
diff --git a/debian/control b/debian/control
index 9326066..101f165 100644
--- a/debian/control
+++ b/debian/control
@@ -1,16 +1,21 @@
-Source: libtext-string-hexconvert-perl
-Priority: extra
-Maintainer: Cyril Bouthors <cyril@debian-packaging.com>
-Uploaders: Cyril Bouthors <cyb@debian.org>, Cyril Bouthors <cyril@bouthors.org>
-Build-Depends: debhelper (>= 8.0.0)
-Standards-Version: 3.9.4
+Source: libstring-hexconvert-perl
+Priority: optional
+Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
+Uploaders: Roland Rosenfeld <roland@debian.org>
+Build-Depends: debhelper-compat (= 13)
+Standards-Version: 4.6.1
 Section: perl
-Homepage: http://search.cpan.org/~ahernit/String-HexConvert/
+Homepage: https://metacpan.org/release/String-HexConvert
+Rules-Requires-Root: no
+Testsuite: autopkgtest-pkg-perl
+Vcs-Git: https://salsa.debian.org/perl-team/modules/packages/libstring-hexconvert-perl.git
+Vcs-Browser: https://salsa.debian.org/perl-team/modules/packages/libstring-hexconvert-perl
 
-Package: libtext-string-hexconvert-perl
-Section: perl
+Package: libstring-hexconvert-perl
 Architecture: all
-Depends: ${shlibs:Depends}, ${misc:Depends}
+Depends: ${misc:Depends}, ${perl:Depends}
+Replaces: libtext-string-hexconvert-perl
+Breaks: libtext-string-hexconvert-perl
 Description: Converts ASCII strings to hexadecimal and reverse
  Wrapper around pack and unpack of Perl to convert a string of hex digits to
  ASCII and other way around.
diff --git a/debian/copyright b/debian/copyright
index d37134b..976b47a 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,41 +1,45 @@
-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-Upstream-Name: libtext-string-hexconvert-perl
-Source: http://search.cpan.org/~ahernit/String-HexConvert/
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Source: https://metacpan.org/release/String-HexConvert
+Upstream-Contact: Andreas Hernitscheck <ahernit@cpan.org>
+Upstream-Name: String-HexConvert
 
 Files: *
-Copyright: 2010 Andreas Hernitscheck <ahernit@cpan.org>
+Copyright: 2014 Andreas Hernitscheck <ahernit@cpan.org>
 License: LGPL-3
- String-HexConvert is free software; you can redistribute it and/or modify it
- under the terms of the GNU Lesser General Public License as published by the
- Free Software Foundation; either version 3 of the License, or (at your option)
- any later version.
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
  .
- String-HexConvert is distributed in the hope that it will be useful, but
- WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for
- more details.
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
  .
- You should have received a copy of the GNU Lesser General Public License along
- with String-HexConvert; if not, write to the Free Software Foundation, Inc., 51
- Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see <http://www.gnu.org/licenses/>.
  .
  On Debian systems, the complete text of the GNU Lesser General
- Public License can be found in "/usr/share/common-licenses/LGPL".
+ Public License can be found in "/usr/share/common-licenses/LGPL-3".
 
-Copyright: 2013 Cyril Bouthors <cyril@debian-packaging.com>
+Files: debian/*
+Copyright:
+ 2013 Cyril Bouthors <cyril@debian-packaging.com>
+ 2022 Roland Rosenfeld <roland@debian.org>
 License: GPL-2+
- This package is free software; you can redistribute it and/or modify
+ This program is free software; you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation; either version 2 of the License, or
  (at your option) any later version.
  .
- This package is distributed in the hope that it will be useful,
+ This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.
  .
- You should have received a copy of the GNU General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>
+ You should have received a copy of the GNU General Public License along
+ with this program; if not, write to the Free Software Foundation, Inc.,
+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  .
  On Debian systems, the complete text of the GNU General
  Public License version 2 can be found in "/usr/share/common-licenses/GPL-2".
diff --git a/debian/rules b/debian/rules
index fac20c9..cbe925d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,3 +1,3 @@
 #!/usr/bin/make -f
 %:
-	dh $@ 
+	dh $@
diff --git a/debian/salsa-ci.yml b/debian/salsa-ci.yml
new file mode 100644
index 0000000..892f3cd
--- /dev/null
+++ b/debian/salsa-ci.yml
@@ -0,0 +1,3 @@
+include:
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
diff --git a/debian/source/format b/debian/source/format
new file mode 100644
index 0000000..163aaf8
--- /dev/null
+++ b/debian/source/format
@@ -0,0 +1 @@
+3.0 (quilt)
diff --git a/debian/watch b/debian/watch
new file mode 100644
index 0000000..1e2dd5e
--- /dev/null
+++ b/debian/watch
@@ -0,0 +1,2 @@
+version=4
+https://metacpan.org/release/String-HexConvert   .*/String-HexConvert-v?@ANY_VERSION@@ARCHIVE_EXT@$

Attachment: signature.asc
Description: PGP signature


Reply to: