hi Francois, I took a look at the gtg package put up for sponsorship in the Python team: * changelog: + multiple entries for revisions that did enter the archive (0.3.1-2 through 4) appear to have gone missing? + there's about a dozen open bugs against the old package, yet only a single one gets closed. Did you review the outstanding bugs and check if any of them are fixed by the new upstream release and/or the revamped packaging? + it's team policy to keep the target distribution at UNRELEASED while a package is under review. + ITP bug not closed upon package reintroduction? * clean: consider converting the entries for deleting pycache stuff at depths other than 3 to also use globbing. * control: + long description should be extended. Assume the reader knows little or nothing about the application at all; what can it do, what makes it special, what services does it integrate with, and so on. Take a look at the upstream homepage if you need inspiration. + why list the old maintainer as uploader? + multiple missing dependencies for utilities called by script_pocketmod. + missing dep gir1.2-secret-1 (for the optional import of gi.repository.Secret in GTG/core/keyring.py) + missing dep for optional import of gi.repository.GnomeKeyring in GTG/core/keyring.py (though it seems that's not yet packaged in Debian so we might have to forego it for now). + missing dep gir1.2-pango-1.0 (for the unconditional import of Pango in GTG/gtk/browser/treeview_factory.py and other files; as well as PangoCairo in GTG/gtk/browser/cell_renderer_tags.py) + unused build-dep on itstool? + lots of build-deps only appear useful for testing; please mark those <!nocheck>. * copyright: + public domain without explanation detailing exactly what exemption the files in question have from default copyright restrictions. + GTG/plugins/dev_console/* headers say LGPL, not GPL. + one Jean-François Fortin Tam is listed in the 'Files: *' paragraph, but only appears as a copyright holder in two files (GTG/core/info.py.in and a single translation). * docs: what purpose does a list of upstream authors serve as end user documentation? * patches: two out of three patches at first glance appear useful for inclusion upstream, yet all are marked 'Forwarded: not-needed'? * rules: + override_dh_auto_install starts by calling dh_auto_install; consider using execute_after_ instead of an override in such cases. + upstream testsuite (based on pytest) not run on build, why? * lintian: + X: gtg: executable-in-usr-lib usr/lib/python3/dist-packages/GTG/plugins/export/export_templates/script_pocketmod (wrong install location per FHS?) + X: gtg: executable-in-usr-lib usr/lib/python3/dist-packages/GTG/core/networkmanager.py (imported as a python module, file probably shouldn't be executable at all?) * autopkgtests: + please change directory to $AUTOPKGTEST_TMP before running test commands to ensure the test doesn't depend on anything from the extracted source pkg, see best practices at [1]. + consider adding an autopkgtest based on the upstream testsuite. * source: variables not properly quoted in 'script_pocketmod', cannot handle spaces (etc.) in the path of the source file; please patch. Once the above comments have been addressed, simply re-add the package to the IRC channel topic. Note: I didn't do any functional testing yet, in light of the need for significant changes to the current packaging. [1]https://wiki.debian.org/ContinuousIntegration/AutopkgtestBestPractices
Attachment:
pgpDN4H7VPc5a.pgp
Description: OpenPGP digital signature