[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#862877: Port from libnm-glib/libnm-util to libnm



Source: kdelibs4support
Version: 5.28.0-2
Severity: normal
User: pkg-utopia-maintainers@lists.alioth.debian.org
Usertags: libnm

Hi,

the libnm-glib/libnm-util libraries have been deprecated upstream in
favour of libnm.

Your package declares a Build-Depends on network-manager-dev.

Afaics, this is used in cmake/modules/FindNetworkManager.cmake to
decide whether to enable NetworkManager support or not and
src/solid-networkstatus/kded/networkmanagerstatus.cpp includes
NetworkManager.h for a couple of defines and the version check macro.

Please consider porting this over to libnm.
libnm provides an API similar to libnm-glib/libnm-util [1].

Since libnm-dev also provides NetworkManager.h, you probably just need
to change cmake/modules/FindNetworkManager.cmake to look for libnm
instead of NetworkManager (or libnm-util) so the include path is
properly set and changing the Build-Depends on network-manager-dev to
libnm-dev.

Since libnm was introduced in network-manager 1.0, you can also drop the
explicit version checks in networkmanagerstatus.cpp via
NM_CHECK_VERSION(0,8,992).

Regards,
Michael

[1] https://developer.gnome.org/libnm/stable/
-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)


Reply to: