Hi Reinhard, On 15-02-2021 15:08, Reinhard Tartler wrote: > Control: severity -1 important I agree with this. The Debian infra allows for use of the internet (if not used to download programs, that's forbidden by ftp-master [1].) > I'm writing as a member of the pkg-go team and am mostly concerned about > potential removal of depending packages. Ack. > The package itself appears to be fine. The tests fail if and only if the > test setup doesn't provide (proper) internet connectivity. In fact, it > tries at test time to reach http://httpbin.org/get > <http://httpbin.org/get> - a service aimed at developing and debugging > programs that do HTTP/REST calls. Please a the "needs-internet" restriction. It's there for this reason. Your package seems to have never failed in testing, so, from the Debian side of things, it looks you're fine. > Based on this, I'm not convinced about removing a significant amount of > packages from the buster release because of this issue. I'm therefore > downgrading the issue to important and would recommend fixing it right > after buster release.> > I'm reaching out to you to confirm this thinking. If you do believe this > is something that ought to be fixed for buster, I'd be happy to upload > the proposed patch to sid right away, as it seems appropriate to disable > the test -- the additional test coverage that it could provide is in no > relationship compared to the effort it would take to fake out the > internet service. There's multiple things to say. 1) test that require internet to test if certain API's out there work are fine *if* annotated with the needs-internet restriction. Personally, I consider using on-line frameworks for that acceptable if the effort to fake is high (that's often the case for maintainers in downstreams like Debian) 2) if possible, those tests should be in a separate autopkgtest paragraph, such then when needs-internet tests are skipped (e.g. because the infra doesn't provide access, like in Ubuntu) the rest of the tests are still run. 3) being robust against network issues is good to build in. autopkgtest itself tries each call to apt three times (with 10 seconds wait in between) to allow for some network issues. Paul [1] https://ftp-master.debian.org/REJECT-FAQ.html [Non-Main II]
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature