[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1056521: marked as done (bookworm-pu: package qbittorrent/4.5.2-3)

Your message dated Sat, 09 Dec 2023 10:20:37 +0000
with message-id <83d3a3621a56b9af1e20d36ee9d390a46ab64a8a.camel@adam-barratt.org.uk>
and subject line Closing requests for updates included in 12.3 point release
has caused the Debian Bug report #1056521,
regarding bookworm-pu: package qbittorrent/4.5.2-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1056521: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1056521
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: qbittorrent@packages.debian.org, marillat@debian.org
Control: affects -1 + src:qbittorrent

[ Reason ]
By default the option "Use UPnP / NAT-PMP to forward the port from my router" in "WebUI" settings is enabled by default. That means by default you expose your client to the internet, even if you are behind a NAT.

[ Impact ]
Outside parties can gain access to webUI through the UPnP, downloaded a dummy torrent, and ran a script via the "run command on torrent completion."

[ Tests ]
This bug has been fixed in qbittorrent 4.5.3 (Released May 28 2023) and work fine.

[ Risks ]
Patch is really simple and break nothing.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
diff -Nru qbittorrent-4.5.2/debian/changelog qbittorrent-4.5.2/debian/changelog
--- qbittorrent-4.5.2/debian/changelog	2023-11-22 16:26:29.000000000 +0100
+++ qbittorrent-4.5.2/debian/changelog	2023-04-21 23:56:17.000000000 +0200
@@ -1,9 +1,3 @@
-qbittorrent (4.5.2-3+deb12u1) bookworm; urgency=medium
-
-  * Disable UPnP for web UI by default in qbittorrent-nox (Closes: #1056379)
-
- -- Christian Marillat <marillat@debian.org>  Wed, 22 Nov 2023 16:26:29 +0100
-
 qbittorrent (4.5.2-3) unstable; urgency=medium
 
   * Really install service file in /lib/systemd/system (Closes: #1034678)
diff -Nru qbittorrent-4.5.2/debian/patches/02_Disable-UPnP-for-web-UI.patch qbittorrent-4.5.2/debian/patches/02_Disable-UPnP-for-web-UI.patch
--- qbittorrent-4.5.2/debian/patches/02_Disable-UPnP-for-web-UI.patch	2023-11-22 15:59:08.000000000 +0100
+++ qbittorrent-4.5.2/debian/patches/02_Disable-UPnP-for-web-UI.patch	1970-01-01 01:00:00.000000000 +0100
@@ -1,14 +0,0 @@
---- a/src/base/preferences.cpp
-+++ b/src/base/preferences.cpp
-@@ -599,11 +599,7 @@ void Preferences::setWebUiPort(const qui
- 
- bool Preferences::useUPnPForWebUIPort() const
- {
--#ifdef DISABLE_GUI
--    return value(u"Preferences/WebUI/UseUPnP"_qs, true);
--#else
-     return value(u"Preferences/WebUI/UseUPnP"_qs, false);
--#endif
- }
- 
- void Preferences::setUPnPForWebUIPort(const bool enabled)
diff -Nru qbittorrent-4.5.2/debian/patches/series qbittorrent-4.5.2/debian/patches/series
--- qbittorrent-4.5.2/debian/patches/series	2023-11-22 15:57:29.000000000 +0100
+++ qbittorrent-4.5.2/debian/patches/series	2023-02-12 18:11:35.000000000 +0100
@@ -1,2 +1 @@
 01_remove-Windows-HDPI.diff
-02_Disable-UPnP-for-web-UI.patch

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 12.3

Hi,

Each of the updates discussed in these requests was included in this
morning's 12.3 bookworm point release.

Regards,

Adam

--- End Message ---
Reply to: