[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: wine-6.0 stable



Hi,

On 16.01.21 16:59, Berillions wrote:
> Hello,
> 
> After some days, hours, minutes and seconds spent, i finally succeed to
> package wine-6.0 which is the new stable version.
> There are some changes between wine-5.5 and 6.0, i used
> wine-development-5.5 debian folder to update to 6.0
> 
> 1- I refreshed debian/clean
> Now, *.ico and *.ttf in dll/*/tests/ are now in source tarball and not
> generated automatically during build.

Unfortunately a no-go for Debian, see my previous mail.



> Zlib entries have been deleted
> ((https://bugs.winehq.org/show_bug.cgi?id=48741
> <https://bugs.winehq.org/show_bug.cgi?id=48741> and cause crash during
> compilation)

Can't comment.


> 
> 2- debian/rules updated.
> - All mention for "makedep" are deleted because since September 2020,
> makedep does not generate single Makefile (see
> https://www.winehq.org/pipermail/wine-cvs/2020-September/147752.html
> <https://www.winehq.org/pipermail/wine-cvs/2020-September/147752.html>)
> It was used in debian/rules to generate Makefile for "libs/port",
> "tools/sfnt2fon", "fonts" and programs manpages.

Can't comment on the "*single* Makefile" change, but regenerating is
needed in Debian.



> 3- Some patches refreshed or deleted
> - binary-indep/manpages.patch deleted (see -2)
> - system/zlib.patch deleted (see -2)
> - generate/icons.patch deleted (*.ico are now available in source tarball)
> - fixes/glibc2.30.patch deleted (implemented upstream)
> - warnings/arm-longdouble.patch (file has been deleted upstream)

The latter 2 sound valid, thanks!



> 4- *### Very Important ###*
> |I disabled "fixes/temporary-directory.patch" in series file because
> there is an issue when i want to create a prefix.|
> |If the is applied, i have this error message : "chdir to
> /tmp/.wine-1000/server-* : No such file or directory" but
> "/run/user/1000/wine/server-*" exists
> |
> |Set *"ln -sf /run/user/1000/wine/ /tmp/.wine-1000"*|
> |*
> *|
> |I precise too that this patch crash the compilation when "dh_auto_test"
> is executed.
> |
> |**|
> |*
> *|
> |--------------------|
> |*
> *|
> There are some others changes not explained here. you can see all my
> change here :
> https://salsa.debian.org/Babaowhisky/wine/-/tree/wine-6.0/debian
> <https://salsa.debian.org/Babaowhisky/wine/-/tree/wine-6.0/debian>

For team collaboration I suggest to put every single change in a
separate commit.  Much easier to review and for cherry-picking helpful
changes.  But that's up to the active team members.



> I'm very not familiar with debian packaging so there are sure to be
> mistakes and things to improve.
> Thanks for the review :-)
> 
> PS : Jens, i add you to this email only for advice if you have since
> your retirement.


Reply to: