Bug#781270: python3-apt: Exception gives Ubuntu-related link on Debian
On Wed, Jun 10, 2015 at 11:34:18PM +0200, W. Martin Borgert wrote:
> On 2015-06-10 17:48, Julian Andres Klode wrote:
> > Thanks for your bug report. I fixed this in git with the
> > following commit:
>
> Thanks! I added a link to the Debian package tracker to it:
>
> diff --git a/apt/package.py b/apt/package.py
> index 641b1a4..47dc0e9 100644
> --- a/apt/package.py
> +++ b/apt/package.py
> @@ -1069,10 +1069,17 @@ class Package(object):
> self._changelog = changelog
>
> except HTTPError:
> - if self.candidate.origins[0].origin == "Ubuntu":
> + if self.candidate.origins[0].origin == "Debian":
> res = _("The list of changes is not available yet.\n\n"
> "Please use "
> - "http://launchpad.net/ubuntu/+source/%s/";
> + "https://tracker.debian.org/media/packages/";
> + "%s/%s/changelog-%s\n"
> + "until the changes become available or try again "
> + "later.") % (prefix, src_pkg, src_ver)
That URL has machine-readable changelogs, so there's no point linking
them, we could just fetch them directly (we currently use a wrong URL). That's
the point here: I don't think we have a life-time changelog view like Ubuntu,
we only have the complete changelog files, so there's no point linking
anywhere.
But ftp-master metadata might be even better, I don't know. Or maybe just
link to the tracker package package, I don't know if the changelog file is
available as soon as the new version is listed in the tracker.
> + elif self.candidate.origins[0].origin == "Ubuntu":
> + res = _("The list of changes is not available yet.\n\n"
> + "Please use "
> + "https://launchpad.net/ubuntu/+source/%s/";
> "%s/+changelog\n"
> "until the changes become available or try again "
> "later.") % (src_pkg, src_ver)
>
> I changed also the launchpad address to HTTPS.
> Would you apply the patch? MTIA!
I don't want to, this will break the translations, and I'd
prefer to keep them intact for now. If you want to patch
them with a sed s/http/https/ (maybe more specific), go ahead.
I might do it myself later this week, but if you do it first,
it'd be less work for me.
--
Julian Andres Klode - Debian Developer, Ubuntu Member
See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
Be friendly, do not top-post, and follow RFC 1855 "Netiquette".
- If you don't I might ignore you.
Reply to: